Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable listing section articles from all locales includig sideloads #654

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Enable listing section articles from all locales includig sideloads #654

wants to merge 1 commit into from

Conversation

ahmedsabriz
Copy link
Contributor

Fixes issue #648

  • Enabled listing articles without the default locale specified
  • Enabled sideloading for help_center.sections.articles endpoint
  • Enabled parsing sideloads as lists or strings in Secondary endpoints similar to primary endpoints

cryptomail
cryptomail reviewed Sep 8, 2024
View reviewed changes
Copy link
Collaborator

@cryptomail cryptomail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would love to see some tests with this :)
In addition maybe mentioning a use case in the readme.
Also....FYI, sideloads are considered harmful and possibly are on the deprecation path here at Zendesk. We are currently dissuading exposing / creating any new sideloads and would dissuade even exposure of them now.
:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cryptomail cryptomail cryptomail left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahmedsabriz @cryptomail